Skip to content

When screen shot is taken file is not overwritten#465

Closed
aaltat wants to merge 24 commits into
robotframework:masterfrom
aaltat:screen_shot_is_not_overwritten
Closed

When screen shot is taken file is not overwritten#465
aaltat wants to merge 24 commits into
robotframework:masterfrom
aaltat:screen_shot_is_not_overwritten

Conversation

@aaltat

@aaltat aaltat commented Jul 24, 2015

Copy link
Copy Markdown
Contributor

When screen shot is taken and if the file already exist, the file name is changed to contain -1 in
the end. Example foobar.png is changed to: foobar-1.png

When screen shot is taken and if the file allready
exit, the file name is changed to contain -001 in
the end. Example foobar.png is changed to:
foobar-1.png
@aaltat

aaltat commented Jul 24, 2015

Copy link
Copy Markdown
Contributor Author

This pull request is same as #426 but all commits has been squashed to a single commit and it is has been merged with latest changes is with master.

@just-be-dev

Copy link
Copy Markdown
Contributor

I'll look over this and test it sometime later this afternoon.

@just-be-dev

Copy link
Copy Markdown
Contributor

@aaltat, I'm sorry for letting this issue float for so long!

I'll really make my best effort to look at it tonight. I've got to wade through this and see what effect the changes I made in #443 are.

@aaltat

aaltat commented Aug 3, 2015

Copy link
Copy Markdown
Contributor Author

@zephraph No problem, this is open source and at least I am doing this for fun. So no stress

@just-be-dev

Copy link
Copy Markdown
Contributor

👍 It's the same for me, but I'll get to it as soon as I can.

@aaltat

aaltat commented Aug 26, 2015

Copy link
Copy Markdown
Contributor Author

Now when 1.7.4 is out, what about this?

@just-be-dev just-be-dev added this to the v1.8 milestone Aug 26, 2015
@just-be-dev

Copy link
Copy Markdown
Contributor

We'll put it on the 1.8 milestone. There are some tweaks I'd like to make.

@aaltat

aaltat commented Aug 26, 2015

Copy link
Copy Markdown
Contributor Author

And it seems to have some conflicts, I will sort those out

@aaltat

aaltat commented Aug 28, 2015

Copy link
Copy Markdown
Contributor Author

Darn making that rebase in that way was not a good idea... Just re-writed the whole history.

OK, I will sort that out, but not tonight, need some sleep that do not anymore make anymore stupid mistakes.

@aaltat

aaltat commented Aug 29, 2015

Copy link
Copy Markdown
Contributor Author

Hmm, perhaps it's easiest to make yet another pull request...

@aaltat

aaltat commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

Because I did screw up the history, created new pull request #501. Closing this on favor of #501

@aaltat aaltat closed this Sep 1, 2015
@aaltat aaltat deleted the screen_shot_is_not_overwritten branch August 8, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants